Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Project samples out of date #1588

Closed
pnadolny13 opened this issue Apr 6, 2023 · 2 comments · Fixed by #2604
Closed

docs: Project samples out of date #1588

pnadolny13 opened this issue Apr 6, 2023 · 2 comments · Fixed by #2604
Assignees
Labels
Documentation Improvements or additions to documentation

Comments

@pnadolny13
Copy link
Contributor

The project samples in https://sdk.meltano.com/en/latest/code_samples.html#project-samples are probably no longer our best implementations to refer users to. Some of those are out dated and havent been maintained in a while.

I'd suggest using MeltanoLabs variants and maybe a few other advanced taps or a simple sample:

Theres probably a ton of others and this is a good suggestion too #728, simply referencing the hub with an SDK filter once we have that functionality available.

@pnadolny13 pnadolny13 changed the title bug: project samples out of date docs bug: project samples out of date Apr 6, 2023
@edgarrmondragon edgarrmondragon added the Documentation Improvements or additions to documentation label Apr 10, 2023
@edgarrmondragon edgarrmondragon changed the title docs bug: project samples out of date docs: Project samples out of date Apr 10, 2023
@stale
Copy link

stale bot commented Aug 8, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Aug 8, 2023
@pnadolny13
Copy link
Contributor Author

Still relevant

@stale stale bot removed the stale label Aug 8, 2023
@edgarrmondragon edgarrmondragon self-assigned this Jul 21, 2024
edgarrmondragon added a commit that referenced this issue Aug 13, 2024
Related:

- Closes #728
- Closes #1588
github-merge-queue bot pushed a commit that referenced this issue Aug 13, 2024
* docs: Update project sample links

Related:

- Closes #728
- Closes #1588

* Fix links

* Fix hub link

* Update docs/code_samples.md

Co-authored-by: Will Da Silva <[email protected]>

---------

Co-authored-by: Will Da Silva <[email protected]>
edgarrmondragon added a commit to MeltanoLabs/tap-cloudwatch that referenced this issue Jan 10, 2025
This was suggested as a project sample in
meltano/sdk#1588, so we might as well make it
a bit shinier:

- Drop support for Python 3.7
- Use Ruff
- Use pre-commit.ci
- Update dependencies

Related:

- meltano/sdk#2604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants