Ensure activate_version is tested in SQL targets

meltano · Mar 6, 2023 · d718c42 · d718c42
1 parent d3f377b
commit d718c42
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/singer_sdk/sinks/sql.py b/singer_sdk/sinks/sql.py
@@ -374,8 +374,10 @@ def activate_version(self, new_version: int) -> None:
         if self.config.get("hard_delete", True):
             with self.connector._connect() as conn, conn.begin():
                 conn.execute(
-                    f"DELETE FROM {self.full_table_name} "
-                    f"WHERE {self.version_column_name} <= {new_version}"
+                    sqlalchemy.text(
+                        f"DELETE FROM {self.full_table_name} "
+                        f"WHERE {self.version_column_name} <= {new_version}"
+                    )
                 )
             return
 

diff --git a/tests/samples/test_target_sqlite.py b/tests/samples/test_target_sqlite.py
@@ -47,10 +47,7 @@ def sqlite_sample_target(sqlite_target_test_config):
 @pytest.fixture
 def sqlite_sample_target_soft_delete(sqlite_target_test_config):
     """Get a sample target object with hard_delete disabled."""
-    conf = sqlite_target_test_config
-    conf["hard_delete"] = False
-
-    return SQLiteTarget(conf)
+    return SQLiteTarget({**sqlite_target_test_config, "hard_delete": False})
 
 
 @pytest.fixture