Remove hardcoded level name from log message

See https://github.com/transferwise/pipelinewise-singer-python/blob/da64a10cdbcad48ab373d4dab3d9e6dd6f58556b/singer/metrics.py#L87
meltano · Apr 3, 2023 · 8f18ade · 8f18ade
1 parent bd442b6
commit 8f18ade
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/docs/implementation/logging.md b/docs/implementation/logging.md
@@ -51,7 +51,7 @@ version: 1
 disable_existing_loggers: false
 formatters:
   metrics:
-    format: "{asctime} {message}"
+    format: "{asctime} {levelname} {message}"
     style: "{"
 handlers:
   metrics:

diff --git a/singer_sdk/metrics.py b/singer_sdk/metrics.py
@@ -97,7 +97,7 @@ def log(logger: logging.Logger, point: Point) -> None:
         logger: An logger instance.
         point: A measurement.
     """
-    logger.info("INFO METRIC: %s", point)
+    logger.info("METRIC: %s", point)
 
 
 class Meter(metaclass=abc.ABCMeta):

diff --git a/tests/core/test_metrics.py b/tests/core/test_metrics.py
@@ -59,7 +59,7 @@ def test_record_counter(caplog: pytest.LogCaptureFixture):
 
     for record in caplog.records:
         assert record.levelname == "INFO"
-        assert record.msg == "INFO METRIC: %s"
+        assert record.msg == "METRIC: %s"
         assert "test=1" in record.message
 
         point: metrics.Point[int] = record.args[0]
@@ -89,7 +89,7 @@ def test_sync_timer(caplog: pytest.LogCaptureFixture):
 
     record = caplog.records[0]
     assert record.levelname == "INFO"
-    assert record.msg == "INFO METRIC: %s"
+    assert record.msg == "METRIC: %s"
 
     point: metrics.Point[float] = record.args[0]
     assert point.metric_type == "timer"