Skip to content

Commit

Permalink
pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Ken Payne committed Jun 7, 2023
1 parent 91064e8 commit 40b4cfa
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions singer_sdk/testing/target_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class TargetInvalidSchemaTest(TargetFileTestTemplate):
def test(self) -> None:
"""Run test."""
# TODO: the SDK should raise a better error than Exception in this case
# https://github.com/meltano/sdk/issues/1755
with pytest.raises(Exception): # noqa: PT011, B017
super().test()

Expand Down Expand Up @@ -97,6 +98,7 @@ class TargetRecordBeforeSchemaTest(TargetFileTestTemplate):
def test(self) -> None:
"""Run test."""
# TODO: the SDK should raise a better error than KeyError in this case
# https://github.com/meltano/sdk/issues/1755
with pytest.raises(KeyError):
super().test()

Expand Down

0 comments on commit 40b4cfa

Please sign in to comment.