FIX: this should be namespace std:: to preserve compatibilty with non-glibc when building without gdb stub #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-glibc when building without gdb stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on updating the OpenBSD port to 1.0rc, which builds with clang on our own libc/++. Currently, building with gdb stub support is broken for us, so I disabled the configure option. But- We don't have
optionallike how glibc does, so we should prependstd::here so building without gdb stub works even without glibc. This should in theory fix other *BSDs as well as musl targets building without gdb stub (if supported). I am unsure if this hack breaks glibc compat, and I don't have a means to test. OK?