Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numbering issue #397

Closed

Conversation

jeloagnasin
Copy link

Checks

Description

Fix issue when there's a non-<li> children in a <ol>. (#369)

@codecov-commenter
Copy link

Codecov Report

Merging #397 into master will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   58.13%   57.82%   -0.31%     
==========================================
  Files           6        6              
  Lines         375      377       +2     
  Branches      124      124              
==========================================
  Hits          218      218              
- Misses         71       73       +2     
  Partials       86       86              
Impacted Files Coverage Δ
src/HTMLRenderers.js 32.00% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 364a4fa...ea6abe0. Read the comment docs.

@jsamr
Copy link
Collaborator

jsamr commented Aug 6, 2020

@jeloagnasin I think you wanted to refer to issue #396, didn't you? Well, it seems this bug was not really a bug. But if you can lay out what this PR "fixes", I'll be happy to help. You will need, as required by the guidelines, to implement tests. Feel free to ask anything in our #contributing Discord channel.

@jsamr jsamr added the is:waiting for feedback Waiting for OP input. label Aug 6, 2020
@jsamr
Copy link
Collaborator

jsamr commented Aug 8, 2020

I'm closing now, but feel free to comment and I'll reopen if deemed appropriate.

@jsamr jsamr closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:waiting for feedback Waiting for OP input.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants