Display attribute restricted to "flex" and "none" #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpamarohorta Thank you so much for your contribution! We're evaluating the possibility of using this library, https://github.com/styled-components/css-to-react-native, to fix all our issues with translated CSS inline rules. If we do, this PR would not be relevant anymore. But since we have not made a decision yet, I will leave it open for now. |
jsamr
requested changes
Jul 10, 2020
| @@ -16,13 +16,13 @@ | |||
| "buffer": "^4.5.1", | |||
| "events": "^1.1.0", | |||
| "html-entities": "^1.2.0", | |||
| "htmlparser2": "^3.10.1", | |||
| "react-native-webview": "^5.6.0" | |||
| "htmlparser2": "^3.10.1" | |||
There was a problem hiding this comment.
You should discard changes on package.json!
| @@ -208,6 +208,9 @@ function cssToRNStyle (css, styleset, { emSize, ptSize, ignoredStyles, allowedSt | |||
| if (key === 'fontSize') { | |||
| return mapAbsoluteFontSize(key, value); | |||
| } | |||
| if (key === 'display' && ['flex', 'none'].indexOf(value) === -1) { | |||
jsamr
added
is:waiting for feedback
|
This PR has been manually merged to a fix branch which will be soon merged to master. See 3d62f2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an element has a display attribute that is not
flexornoneit will give an error (e.g. issue 257).This PR introduces a validation to only allow those 2 values and default to
flexif otherwise.Thanks for the amazing library!