-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dumps
features
#616
Add dumps
features
#616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot :) Could you add the two new functions at the bottom of the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks!
Just one question... I don't understand how the exceptions are handled in the tests (not very familiar with this js errors). Let me explain: I have the impression that errors thrown are relying on the "message" that the server send! If that's the case, I think it should check the errorCode instead of the error message, since error codes are meant to be stable, while error messages can be changed by MeilISearch anytime!
Nothing else to add for now, thanks for this contribution :)
Hey @eskombro this is because I used the following await expect(SpecificFunction).rejects.toThrowError(ErrorMessage) Which uses the printed output of the error, so in our case, the |
@neupauer awesome work!! Really clear, thank you for that! Tips: I see you do this PR from your |
@bidoubiwa I updated the @bidoubiwa, @eskombro, @curquiza Thank you for your feedback. |
- add `createDump` - add `getDumpStatus` Signed-off-by: Peter Neupauer <[email protected]>
This PR adds features to manage
dumps
introduced in v0.15