Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package exports #1737

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Oct 4, 2024

Pull Request

Related issue

Fixes #1736

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the bug Something isn't working label Oct 4, 2024
@flevi29
Copy link
Collaborator Author

flevi29 commented Oct 4, 2024

@curquiza sorry 😅!

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (8f43b17) to head (77f914b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1737   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          20       20           
  Lines        1513     1513           
  Branches      319      319           
=======================================
  Hits         1476     1476           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, thank you for the fix @flevi29

bors merge

Copy link
Contributor

meili-bors bot commented Oct 4, 2024

@meili-bors meili-bors bot merged commit 03130bf into meilisearch:main Oct 4, 2024
7 checks passed
@flevi29 flevi29 deleted the fix-package-exports branch October 4, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM is broken with Vite in 0.44.0
2 participants