fix manifest v3 issue #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, I was just working on this |
optimisan
suggested changes
Nov 23, 2023
Comment on lines
+23
to
+27
| "script.js", | ||
| "style.css", | ||
| "icon.png", | ||
| "manifest.json", | ||
| "csp.js" |
There was a problem hiding this comment.
Are you sure you need all these?
Only csp.js is working for me.
Comment on lines
+32
to
+33
| script.src = chrome.runtime.getURL('public/csp.js') ; | ||
| (document.head || document.documentElement).appendChild(script); |
There was a problem hiding this comment.
Refactor content.ts
Since csp.js is a separate file, I think content.ts is doing too many things.
We can remove this disabling business out of content.ts and keep this as a content script instead of injecting.
csp.js will inject the code instead, which can be something like this:
const disablingCode = ```$('#sortable_nav').sortable('destroy');
$('#sortable_nav').enableSelection();
```
const script = document.createElement('script');
script.textContent = disablingCode;
(document.head || document.documentElement).appendChild(script);There was a problem hiding this comment.
This should be a separate pull request though.
| "activeTab", | ||
| "scripting" | ||
| ], | ||
| "action": {}, |
There was a problem hiding this comment.
The default_icon key is recommended here (which is basically a copy-paste from the icons above).
Also, you can add a default_title here that is shown as a tooltip on hover:
"action": {
"default_icon": {
"32": "icon.png",
"48": "icon.png",
"64": "icon.png",
"128": "icon.png"
},
"default_title": "Click to run PS-Extender"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest v2 is now deprecated, and thus the shift to v3 was needed