Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter empty detections in labels #74

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Filter empty detections in labels #74

merged 1 commit into from
Apr 15, 2024

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Apr 15, 2024

Fix overcounting instances when the label values are not contiguous.

@ziw-liu ziw-liu requested a review from edyoshikun April 15, 2024 20:27
@ziw-liu ziw-liu added the bug Something isn't working label Apr 15, 2024
edyoshikun
edyoshikun approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for when the labels are not in a sequence. I tested this with the datasets that I got and compared the mAP with PQ's RQ and get very similar results.

@ziw-liu ziw-liu merged commit c30afe8 into main Apr 15, 2024
3 checks passed
@ziw-liu ziw-liu deleted the filter-labels branch April 15, 2024 22:40
edyoshikun pushed a commit that referenced this pull request Jun 12, 2024
@ziw-liu @edyoshikun
filter empty detections (#74)
f7b10c7
edyoshikun pushed a commit that referenced this pull request Jun 12, 2024
@ziw-liu @edyoshikun
filter empty detections (#74)
834af17
edyoshikun pushed a commit that referenced this pull request Jun 12, 2024
@ziw-liu @edyoshikun
filter empty detections (#74)
23689e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyoshikun edyoshikun edyoshikun approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziw-liu @edyoshikun