add unit test

mehdi-aouadi · Feb 5, 2025 · 4690377 · 4690377
1 parent 1c0f6eb
commit 4690377
Showing 1 changed file with 34 additions and 0 deletions.
diff --git a/...r/client/src/test/java/tech/pegasys/teku/validator/client/loader/ValidatorLoaderTest.java b/...r/client/src/test/java/tech/pegasys/teku/validator/client/loader/ValidatorLoaderTest.java
@@ -47,6 +47,7 @@
 import tech.pegasys.teku.bls.BLSPublicKey;
 import tech.pegasys.teku.bls.BLSSignature;
 import tech.pegasys.teku.bls.keystore.KeyStoreLoader;
+import tech.pegasys.teku.bls.keystore.model.KeyStoreData;
 import tech.pegasys.teku.infrastructure.async.SafeFuture;
 import tech.pegasys.teku.infrastructure.async.StubAsyncRunner;
 import tech.pegasys.teku.infrastructure.exceptions.InvalidConfigurationException;
@@ -748,6 +749,39 @@ void shouldLoadMutableValidatorIfEnabled(@TempDir final Path tempDir) throws Exc
     assertThat(validator.get().getGraffitiProvider()).isInstanceOf(UpdatableGraffitiProvider.class);
   }
 
+  @Test
+  void shouldCheckKeystorePasswordWhenNotAddingValidatorToOwned(@TempDir final Path tempDir)
+      throws Exception {
+    final ValidatorConfig config = ValidatorConfig.builder().build();
+    final ValidatorLoader validatorLoader =
+        ValidatorLoader.create(
+            spec,
+            config,
+            disabledInteropConfig,
+            httpClientFactory,
+            slashingProtector,
+            slashingProtectionLogger,
+            publicKeyLoader,
+            asyncRunner,
+            metricsSystem,
+            Optional.of(new SimpleDataDirLayout(tempDir)),
+            (publicKey) -> Optional.empty());
+    validatorLoader.loadValidators();
+
+    final String keystoreString =
+        Resources.toString(Resources.getResource("pbkdf2TestVector.json"), StandardCharsets.UTF_8);
+    final KeyStoreData keystoreData = KeyStoreLoader.loadFromString(keystoreString);
+    ValidatorImportResult result =
+        validatorLoader.loadLocalMutableValidator(
+            keystoreData, "incorrectPassword", Optional.empty(), false);
+    assertThat(result.getPostKeyResult().getImportStatus()).isEqualTo(ImportStatus.ERROR);
+    assertThat(result.getPostKeyResult().getMessage())
+        .isEqualTo(
+            Optional.of(
+                "Invalid keystore password for public key: "
+                    + keystoreData.getAbbreviatedPubKey()));
+  }
+
   @Test
   void doNotInitializeInteropValidatorsWhenInteropIsDisabled() {
     final int ownedValidatorCount = 10;