Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ioctl-sys to 0.6 #28

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Bump ioctl-sys to 0.6 #28

merged 1 commit into from
Feb 22, 2021

Conversation

Ch00k
Copy link
Contributor

@Ch00k Ch00k commented Feb 11, 2021

This adds support for Apple Silicon. Support for it in ioctl-sys was introduced in this PR: codyps/ioctl#7

@meh
Copy link
Owner

meh commented Feb 22, 2021

Thanks, I'm going to try to merge this and publish a new package when I get home.

But please, if I don't, don't feel like you're bothering me with pings, I'm quite busy and tired so it's more likely that I got home and fell asleep than anything, so do ping me if I don't, even multiple times, or send a message pigeon with a firecracker or something.

@meh meh merged commit 18928d9 into meh:master Feb 22, 2021
@faern
Copy link

faern commented Feb 23, 2021

Yay! Awesome to have it merged. Would it be possible to have a (patch?) release published with this?

@meh
Copy link
Owner

meh commented Feb 23, 2021

Yeah, I was working on that, then I noticed tokio was outdated, so I started upgrading, but mio was also outdated, and then I fell asleep.

I'll try to finish that later today and release a new version :)

@faern
Copy link

faern commented Feb 23, 2021

Can we please have a tun release that depends on tokio 0.2 first/also? 🙏

Many of us are still stuck with tokio 0.2 and can't upgrade in the forseeable future. So if you change tun we will not be able to upgrade.

@faern
Copy link

faern commented Feb 23, 2021

A quick patch release just allowing Apple Silicon via the bumped ioctl-sys would be amazing (0.5.1)! And then there can be a separate breaking change for the new tokio ecosystem? (0.6.0)

@meh
Copy link
Owner

meh commented Feb 23, 2021

Of course, I'll do that when I get to the studio.

@meh
Copy link
Owner

meh commented Feb 23, 2021

@faern it's up on crates!

@faern
Copy link

faern commented Feb 23, 2021

Thank you @meh ! <3

zonyitoo pushed a commit to zonyitoo/rust-tun that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants