log error when meet invalid json (#473)

notify/ringcentral/ringcentral.go

@@ -20,6 +20,7 @@ package ringcentral
 
 import (
 	"bytes"
+	"encoding/json"
 	"errors"
 	"fmt"
 	"io"
@@ -75,6 +76,9 @@ func (c *NotifyConfig) SendRingCentral(title, msg string) error {
 		]
 	 }
 	`, report.JSONEscape(title), report.JSONEscape(msg))
+	if !json.Valid([]byte(msgContent)) {
+		log.Errorf("[%s / %s ] - %v, err: invalid json", c.Kind(), c.Name(), msgContent)
+	}
 
 	req, err := http.NewRequest(http.MethodPost, c.WebhookURL, bytes.NewBuffer([]byte(msgContent)))
 	if err != nil {

notify/slack/slack.go

@@ -78,8 +78,5 @@ func (c *NotifyConfig) SendSlackNotification(msg string) error {
 		log.Debugf(msg)
 		return fmt.Errorf("Error response from Slack - code [%d] - msg [%s]", resp.StatusCode, string(buf))
 	}
-	// if buf.String() != "ok" {
-	// 	return errors.New("Non-ok response returned from Slack " + buf.String())
-	// }
 	return nil
 }

notify/wecom/wecom.go

@@ -20,6 +20,7 @@ package wecom
 
 import (
 	"bytes"
+	"encoding/json"
 	"fmt"
 	"io"
 	"net/http"
@@ -64,6 +65,10 @@ func (c *NotifyConfig) SendWecomNotification(msg string) error {
 		}
 	}
 	`, report.JSONEscape(msg))
+	if !json.Valid([]byte(msgContent)) {
+		log.Errorf("[%s / %s ] - %v, err: invalid json", c.Kind(), c.Name(), msgContent)
+	}
+
 	req, err := http.NewRequest(http.MethodPost, c.WebhookURL, bytes.NewBuffer([]byte(msgContent)))
 	if err != nil {
 		return err

report/result.go

@@ -159,8 +159,7 @@ func markdown(r probe.Result, f Format) string {
 // ToSlack convert the object to ToSlack notification
 // Go to https://app.slack.com/block-kit-builder to build the notification block
 func ToSlack(r probe.Result) string {
-
-	json := `
+	jsonMsg := `
 	{
 		"text": "%s",
 		"blocks": [
@@ -193,13 +192,17 @@ func ToSlack(r probe.Result) string {
 		r.Title(), r.Status.Emoji(), r.Endpoint, rtt, JSONEscape(r.Message))
 	context := SlackTimeFormation(r.StartTime, " probed at ", global.GetTimeFormat())
 	summary := fmt.Sprintf("%s %s - %s", r.Title(), r.Status.Emoji(), JSONEscape(r.Message))
-	return fmt.Sprintf(json, summary, body, context)
+	output := fmt.Sprintf(jsonMsg, summary, body, context)
+	if !json.Valid([]byte(output)) {
+		log.Errorf("ToSlack() for %s: Invalid JSON: %s", r.Name, output)
+	}
+	return output
 }
 
 // ToLark convert the object to Lark notification
 // Go to https://open.feishu.cn/document/ukTMukTMukTM/ucTM5YjL3ETO24yNxkjN#4996824a to build the notification block
 func ToLark(r probe.Result) string {
-	json := `
+	jsonMsg := `
 	{
 		"msg_type": "interactive",
 		"card": {
@@ -253,7 +256,11 @@ func ToLark(r probe.Result) string {
 	rtt := r.RoundTripTime.Round(time.Millisecond)
 	content := fmt.Sprintf("%s - ⏱ %s\\n%s", r.Endpoint, rtt, JSONEscape(r.Message))
 	footer := global.FooterString() + " probed at " + FormatTime(r.StartTime)
-	return fmt.Sprintf(json, headerColor, title, content, footer)
+	output := fmt.Sprintf(jsonMsg, headerColor, title, content, footer)
+	if !json.Valid([]byte(output)) {
+		log.Errorf("ToLark() for %s: Invalid JSON: %s", r.Name, output)
+	}
+	return output
 }
 
 // ToCSV convert the object to CSV

report/sla.go

@@ -251,7 +251,7 @@ func SLAHTMLFilter(probers []probe.Prober, filter *SLAFilter) string {
 // SLASlackSection return the slack json format string to stat
 func SLASlackSection(r *probe.Result) string {
 
-	json := `
+	jsonMsg := `
 			{
 				"type": "mrkdwn",
 				"text": "*%s* - %s` +
@@ -268,10 +268,14 @@ func SLASlackSection(r *probe.Result) string {
 		message = "`" + message + "`"
 	}
 
-	return fmt.Sprintf(json, r.Name, JSONEscape(r.Endpoint),
+	output := fmt.Sprintf(jsonMsg, r.Name, JSONEscape(r.Endpoint),
 		DurationStr(r.Stat.UpTime), DurationStr(r.Stat.DownTime), r.SLAPercent(),
 		r.Stat.Total, SLAStatusText(r.Stat, MarkdownSocial),
 		t, r.Status.Emoji()+" "+r.Status.String(), message)
+	if !json.Valid([]byte(output)) {
+		log.Errorf("SLASlackSection() for %s: invalid json: %s", r.Name, output)
+	}
+	return output
 }
 
 // SLASlack generate all probes stat message to slack block string
@@ -391,7 +395,7 @@ func SLALarkSection(r *probe.Result) string {
 
 // SLALark return a full stat report
 func SLALark(probers []probe.Prober) string {
-	json := `
+	jsonMsg := `
 	{
 		"msg_type": "interactive",
 		"card": {
@@ -429,7 +433,11 @@ func SLALark(probers []probe.Prober) string {
 	}
 
 	elements := strings.Join(sections, "")
-	s := fmt.Sprintf(json, title, elements)
+	s := fmt.Sprintf(jsonMsg, title, elements)
+	if !json.Valid([]byte(s)) {
+		log.Errorf("SLALark(): invalid json: %s", s)
+	}
+
 	fmt.Printf("SLA: %s\n", s)
 	return s
 }