Added support for datachannel label/protocol to Lua and Duktape plugins #2641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that, despite labels and subprotocols support had been added to Janus for some time already (in #1551 and #2157 respectively), we still hadn't updated the Lua and Duktape plugins accordingly. This is what this patch does.
In theory, this change is backwards compatible, meaning that if you're using datachannels and don't change anything in your lua and js script, they should just work, but you may want to double check that. Label and subprotocol are now two additional (and again, in theory optional) parameters you can add both to your
incomingTextData
/incomingBinaryData
callbacks, and the relatedrelayTextData
/relayBinaryData
methods. I updated bothechotest.lua
andechotest.js
, so it should be trivial to see how you can change your scripts.Feedback welcome, as I plan to merge soon.