Pass MQTT buffer settings to Paho #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks for this new contribution! Merging 👍 |
bartbalaz
pushed a commit
to bartbalaz/janus-gateway
that referenced
this pull request
Jul 21, 2020
* Pass max inflight setting to Paho * Pass max buffered setting to Paho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is out of scope of the previous PR so here is a separate one.
This feature allows passing a couple of options to Paho MQTT client through transport & evh configs: max inflight messages and max buffered messages. By default Paho sets the first one to 10 and the second one to 100 which may be insufficient for high load. So here're options to configure them.