User talking #2158
Merged
User talking #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st improvements compact json next finnal version
Feature/gelf udp support
initial commit
Feature/gelf compression
Feature/gelf compression
First connect then start thread
…d are not lost (since they are not present in every message)
Feature/gelf compression
Code style and removals
Feature/gelf compression
Feature/gelf compression
Feature/gelf compression
Feature/gelf compression
lminiero
reviewed
May 18, 2020
|
It does make sense, thanks! I think adding it to the VideoRoom too would indeed help. |
added 2 commits
May 18, 2020 18:57
|
added to videoroom also, I haven't tested Configure request with this values, but I hope it will work if someone wants to change tem later after joining room |
|
Thanks! I noticed a couple of small things that need to be fixed on code style, but I can take care of those myself. Merging 👍 |
lminiero
added a commit
that referenced
this pull request
May 20, 2020
|
oh thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a per-user override of global room values of audio_active_packets and audio_level_average, since different users will have different microphone input levels (volume and gain).
It is less likely in practice to find settings of one user to fit another one.
@lminiero , if this makes sense and is implemented "just right" , let me know to add it to videoroom also.
Thanks for the feedback,
Mirko