Add caching for iso, kic, and preload #46
Conversation
| return cacheHits | ||
| } | ||
|
|
||
| async function getMinikubeVersion(): Promise<string> { |
There was a problem hiding this comment.
this is not used yet, right ? if so lets comment on top of it (to be used later to cache binary)
There was a problem hiding this comment.
This is currently being used for adding the version to cache keys.
There was a problem hiding this comment.
does that mean if Preload stays same but minikube version changes, it wont use that prelaod from old minikube version in cache ?
There was a problem hiding this comment.
That's correct, my one worry is if we bump the preload version (v18) between releases that we don't want to keep using the old version.
The two options I can think of if we don't want to change the preload cache between minikube versions is:
1. Look at the contents of the preload directory to get the version (This won't work as we don't know the preload version before we start minikube)
2. Add a preload version command to minikube that reports the version of the preload
Related #16