-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework): add missing storefrontUrl from configuration type #11511
Conversation
🦋 Changeset detectedLatest commit: 65c58be The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small suggestion
Co-authored-by: Kasper Fabricius Kristensen <[email protected]>
The
storefrontUrl
is defined in thepackages/core/types/src/common/config-module.ts
file, but for many purposes, including the documentation, we use the types defined inpackages/core/framework/src/config/types.ts
. This PR adds thestorefrontUrl
to the framework type