fix: Minor fixes and cleanup to the payments setup (#11356)

This PR adds a couple new statuses to the payment collection and payment webhook results. The payment collection will now be marked as "completed" once the captured amount is the full amount of the payment collection.

There are several things left to improve the payment setup, so non-happy-path cases are handled correctly.
1. Currently the payment session and payment models serve a very similar purpose. Part of the information is found on one, and the other part on the other model, without any clear reason for doing so. We can simplify the payment module and the data models simply by merging the two.
2. We need to handle failures more gracefully, such as setting the payment session status to failed when such a webhook comes in.
3. We should convert the payment collection status and the different amounts to calculated fields from the payment session, captures, and refunds, as they can easily be a source of inconsistencies.

integration-tests/http/__tests__/claims/claims.spec.ts

@@ -833,7 +833,7 @@ medusaIntegrationTestRunner({
             expect.objectContaining({
               currency_code: "usd",
               amount: paymentDelta,
-              status: "authorized",
+              status: "completed",
               authorized_amount: paymentDelta,
               captured_amount: paymentDelta,
               refunded_amount: 0,

integration-tests/http/__tests__/order/admin/rma-flows.spec.ts

@@ -346,8 +346,7 @@ medusaIntegrationTestRunner({
         expect(paymentCollection).toEqual(
           expect.objectContaining({
             amount: 200,
-            // Q: Shouldn't this be paid?
-            status: "authorized",
+            status: "completed",
             payment_sessions: [
               expect.objectContaining({
                 status: "authorized",
@@ -639,8 +638,7 @@ medusaIntegrationTestRunner({
         expect(paymentCollection).toEqual(
           expect.objectContaining({
             amount: 115.9,
-            // Q: Shouldn't this be paid?
-            status: "authorized",
+            status: "completed",
             payment_sessions: [
               expect.objectContaining({
                 status: "authorized",

packages/core/core-flows/src/payment/steps/capture-payment.ts

@@ -38,4 +38,6 @@ export const capturePaymentStep = createStep(
 
     return new StepResponse(payment)
   }
+  // We don't want to compensate a capture automatically as the actual funds have already been taken.
+  // The only want to compensate here is to issue a refund, but it's better to leave that as a manual operation for now.
 )

packages/core/core-flows/src/payment/steps/refund-payment.ts

@@ -38,4 +38,6 @@ export const refundPaymentStep = createStep(
 
     return new StepResponse(payment)
   }
+  // We don't want to compensate a refund automatically as the actual funds have already been sent
+  // And in most cases we can't simply do another capture/authorization
 )

packages/core/types/src/http/payment/common.ts

@@ -9,7 +9,8 @@ export type BasePaymentCollectionStatus =
   | "authorized"
   | "partially_authorized"
   | "canceled"
-
+  | "completed"
+  | "failed"
 /**
  *
  * The status of a payment session.

packages/core/types/src/payment/common.ts

@@ -10,6 +10,8 @@ export type PaymentCollectionStatus =
   | "authorized"
   | "partially_authorized"
   | "canceled"
+  | "failed"
+  | "completed"
 
 export type PaymentSessionStatus =
   | "authorized"