Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build file based catalog #252

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Shai1-Levi
Copy link
Contributor

@Shai1-Levi Shai1-Levi commented Jan 29, 2025

Why we need this PR

Currently SNR Makefile creates a db-based catalog, which was deprecated

Changes made

This change create a file-based catalog

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-2583

Test plan

  • Create the file-based catalog and push it to my quay.io repository via Makefile
  • Create a CatalogSource pointing to the new catalog
  • Install SNR via WebUI, verify that everything works

Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

Hi @Shai1-Levi. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@razo7
Copy link
Member

razo7 commented Jan 30, 2025

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, Shai1-Levi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member

razo7 commented Jan 30, 2025

/hold
The last commit should be avoided as I have missed the usage of hyphen

@razo7
Copy link
Member

razo7 commented Jan 30, 2025

/unhold
/lgtm
/ok-to-test

@openshift-merge-bot openshift-merge-bot bot merged commit 7822739 into medik8s:main Jan 30, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants