Rename master -> control-plane and support control-plane node taint

[malt3]

Extending on my other PR, the old naming of "master" is long deprecated and control-plane is used instead. This PR renames mentions of master to be called control-plane instead and adds support to detect control-plane nodes using the control-plane node taint node-role.kubernetes.io/control-plane.

This is quite a large change so I understand if not all parts are accepted.

[openshift-ci]

Hi @malt3. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[razo7]

/ok-to-test

[slintes]

Thanks for this follow up to #52 👍🏼
Looks mostly good to me, but I spotted 2 places where I think we need to use both old and new master / control-plane labels for backwards compatibility.

[razo7]

We prefer to support both of the names, master, and control-plane, since we plan to support old OCP versions, where there are only master and worker roles.
Therefore, it would be better if you can rename master -> master/control-plane for logs. @malt3

[slintes]

thanks for the quick update!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: malt3, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[slintes]

/hold

leaving final review to @razo7

[razo7]

/lgtm
Thanks for the help @malt3 !

[malt3]

Great! Should I squash the changes or will the bot take care of that?

[razo7]

The bot doesn't squash commits. Please squash them.

[razo7]

/lgtm

[slintes]

/hold cancel