Update the status of nm CR in README #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
beekhof
reviewed
Jul 7, 2022
README.md
Outdated
| `drainProgress` shows the percentage completion of draining the node. | ||
|
|
||
| `evictionPods` is the total number of pods up for eviction from the start. |
There was a problem hiding this comment.
Suggested change
| `evictionPods` is the total number of pods up for eviction from the start. | |
| `evictionPods` is the total number of pods up for eviction before the node entered maintenance mode. |
There was a problem hiding this comment.
I liked the wording you used below :)
razo7
force-pushed
the
update-status-fields-readme
branch
from
74620e2 to
f4063f6
Compare
razo7
force-pushed
the
update-status-fields-readme
branch
from
f4063f6 to
dfb5e11
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR, #41, I have forgotten to add the CR's new status fields in README's example