Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Replace Annotation #108

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Dec 26, 2023

Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version and ensure that the old version isn't deleted from the index.

https://docs.engineering.redhat.com/display/CFC/Best_Practices#Best_Practices-SkipRange

Similar to medik8s/self-node-remediation#167 and related to ECOPROJECT-1771

Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version, and ensures that the old version isn't deleted from the index.
Set bundle csv location once
Copy link
Contributor

openshift-ci bot commented Dec 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member

/test ?

Copy link
Contributor

openshift-ci bot commented Dec 27, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-index
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.13-ci-index
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.14-ci-index
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.15-ci-index
  • /test 4.15-images
  • /test 4.15-openshift-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member

/test 4.13-openshift-e2e

@razo7
Copy link
Member Author

razo7 commented Dec 27, 2023

/test 4.15-openshift-e2e

@mshitrit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 28, 2023
@mshitrit mshitrit marked this pull request as ready for review December 31, 2023 07:28
@openshift-ci openshift-ci bot requested review from beekhof and slintes December 31, 2023 07:28
@razo7
Copy link
Member Author

razo7 commented Dec 31, 2023

/retest

2 similar comments
@razo7
Copy link
Member Author

razo7 commented Dec 31, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Dec 31, 2023

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 9bfe371 into medik8s:main Dec 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants