Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add subscribe RegisterOracle Tx and execute ApproveOracleRegistration Tx #21

Merged
merged 12 commits into from
Dec 13, 2022
Merged

feat: add subscribe RegisterOracle Tx and execute ApproveOracleRegistration Tx #21

merged 12 commits into from
Dec 13, 2022

Conversation

inchori
Copy link
Contributor

@inchori inchori commented Dec 8, 2022 •
edited
Loading

Closes #3
Closes #4

Actually, I missed that the two issues were separated. Sorry for about that.

  • Add a subscribe RegisterOracle Tx and add a register-oracle cmd in register_oracle.go.
  • Add an EventHandler in register_oracle_event.go so that executing ApproveOracleRegistration Tx.

@inchori inchori added this to the v2.1.0-beta milestone Dec 8, 2022
@inchori inchori self-assigned this Dec 8, 2022
@inchori inchori marked this pull request as draft December 8, 2022 07:56
@inchori inchori marked this pull request as ready for review December 8, 2022 08:03
gyuguen
gyuguen reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Please check my comment

event/oracle/event.go Outdated Show resolved Hide resolved
crypto/encrypt.go Outdated Show resolved Hide resolved
crypto/encrypt.go Outdated Show resolved Hide resolved
audtlr24
audtlr24 reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work.
I haven't done a review yet, I left few comments.

0xHansLee
0xHansLee reviewed Dec 12, 2022
View reviewed changes
cmd/oracled/cmd/register_oracle.go Outdated Show resolved Hide resolved
event/oracle/register_oracle_event.go Outdated Show resolved Hide resolved
event/oracle/event.go Outdated Show resolved Hide resolved
event/oracle/register_oracle_event.go Outdated Show resolved Hide resolved
youngjoon-lee
youngjoon-lee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but please fix the nonce handling of AES encryption, as gyuguen explained.

audtlr24
audtlr24 reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed it in my previous review.

cmd/oracled/cmd/register_oracle.go Outdated Show resolved Hide resolved
gyuguen
gyuguen approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xHansLee
0xHansLee approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thx man 👍

@inchori inchori merged commit 18cf18d into main Dec 13, 2022
@inchori inchori deleted the ft/3/subscribe_register_oracle branch December 13, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audtlr24 audtlr24 audtlr24 left review comments

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
v0.0.1-alpha.1
Development

Successfully merging this pull request may close these issues.

Execute ApproveOracleRegistration tx Subscribe RegisterOracle tx
5 participants
@inchori @youngjoon-lee @gyuguen @audtlr24 @0xHansLee