feat: improve block height specification for query #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuguen
commented
Mar 7, 2023
| @@ -59,12 +57,6 @@ func (s *PanaceaSubscriber) subscribe(event Event) error { | |||
| for tx := range txs { | |||
| ctx := context.Background() | |||
|
|
|||
| height, err := strconv.ParseInt(tx.Events["tx.height"][0], 10, 64) | |||
There was a problem hiding this comment.
We no longer take the block height received as an event and use it .
We always use the cached block height.
gyuguen
commented
Mar 7, 2023
gyuguen
commented
Mar 7, 2023
| mutex *sync.Mutex | ||
| cdc *codec.ProtoCodec | ||
| aminoCdc *codec.AminoCodec | ||
| cachedLastBlockHeight int64 |
There was a problem hiding this comment.
The cached block height is managed here.
gyuguen
commented
Mar 7, 2023
| }, nil | ||
| } | ||
|
|
||
| go queryClient.startSchedulingLastBlockCaching() |
There was a problem hiding this comment.
I made some modifications to the existing refresh().
gyuguen
commented
Mar 7, 2023
panacea/query_client.go
Outdated
| } | ||
| return q.GetLastBlockHeight(ctx) | ||
| func (q *verifiedQueryClient) getQueryBlockHeight() int64 { | ||
| return q.cachedLastBlockHeight - 1 |
There was a problem hiding this comment.
Always do -1 in the last block, because the appHash is always in the next block. This is the same as the previous spec.
audtlr24
approved these changes
Mar 7, 2023
0xHansLee
reviewed
Mar 8, 2023
|
@audtlr24 @H4NLee @youngjoon-lee |
inchori
reviewed
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #100
Implementation