This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Tests - Adding route tests for user/admin CRUD operations #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| }; | ||
|
|
||
| user = new User(_user); | ||
|
|
||
| // Save a user to the test db and create new article | ||
| user.save(function () { |
There was a problem hiding this comment.
Shouldn't we check that the user was saved and an error wasn't thrown?
|
@ilanbiala thanks, great feedback! |
|
@ilanbiala any ideas why I don't see the coverage status here? did something break there? |
|
@lirantal I noticed that, I'm not sure exactly why but Coveralls had the last build as 1352. I just restarted the build so hopefully Coveralls will get that one. |
|
Yep, now it's there, thanks. |
lirantal
force-pushed
the
feature/user-route-tests-improve
branch
from
79715d2 to
6d9f01e
Compare
|
@ilanbiala updated and addressed all your comments. |
|
@lirantal one more return missed that I didn't see before. https://github.com/meanjs/mean/pull/928/files#diff-f2da820fbb902b375a9e67035ac86c1bR152 Other than that, LGTM. |
|
missed it, thanks! |
lirantal
force-pushed
the
feature/user-route-tests-improve
branch
from
6d9f01e to
de354ee
Compare
|
LGTM. |
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Sep 22, 2015
Tests - Adding route tests for user/admin CRUD operations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.