This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Update Bower manifest #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simison
commented
Sep 16, 2015
simison
commented
- Remove deprecated "version": http://bower.io/docs/creating-packages/#version
- Add "license"
- Add "homepage"
- Use fuzzier version requirement for angular-messages (~)
| @@ -12,7 +13,7 @@ | |||
| "angular-ui-utils": "bower", | |||
| "angular-ui-router": "~0.2", | |||
| "angular-file-upload": "1.1.5", | |||
| "angular-messages": "1.3.17", | |||
| "angular-messages": "~1.3", | |||
There was a problem hiding this comment.
Can we leave the .17 so we know what version it was brought in and tested with? That's helpful when a new version is released and it contains some random bug and we need to revert.
There was a problem hiding this comment.
I don't mind, tho this goes quite much into bikeshedding category anyway. :-)
Angular-messages is a core module, so it should be pretty solid and reliable for minor 1.3.x updates, just like the rest of the angular-* packages listed there. Just sayin'.
There was a problem hiding this comment.
👍 Squash and I'll give my approval. Thanks! :)
|
@simison Left a line comment. Otherwise looks good. |
- Remove deprecated "version": http://bower.io/docs/creating-packages/#version - Add "license" - Add "homepage" - Use fuzzier version requirement for angular-messages (~)
|
@codydaig Squashed. |
|
LGTM! @simison Thanks! :-D |
|
LGTM |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.