Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

mask exception route for 404 responses. #844

Merged
merged 1 commit into from
Aug 23, 2015
Merged

mask exception route for 404 responses. #844

merged 1 commit into from
Aug 23, 2015
+5 −1

Conversation

rhutchison
Copy link
Contributor

This will mask the not-found route by showing the not-found page without redirecting to the not-found state.

Steps
  1. http://localhost:3000/khdshskddsakh
Expected
  • Route should not change.
  • User should see page not found.

@lirantal lirantal added this to the 0.4.x milestone Aug 23, 2015
@lirantal lirantal self-assigned this Aug 23, 2015
@codydaig
Copy link
Member

LGTM

lirantal added a commit that referenced this pull request Aug 23, 2015
@lirantal
Merge pull request #844 from Gym/404-behavior
b8147cb 
mask exception route for 404 responses.
@lirantal lirantal merged commit b8147cb into meanjs:master Aug 23, 2015
@rhutchison rhutchison deleted the 404-behavior branch August 26, 2015 04:35
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2020
Open
@isp1r0 isp1r0 mentioned this pull request Oct 18, 2022
Open
@SibuStephen SibuStephen mentioned this pull request Oct 18, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@lirantal lirantal

Labels
enhance:feature need:review+1
Projects
None yet
Milestone
0.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@rhutchison @codydaig @lirantal