-
Notifications
You must be signed in to change notification settings - Fork 2k
Remove generator references from readme and index #734
Conversation
@lirantal maybe we should even say that the generator is out-of-date and should not be used until further notice to prevent more issues? |
@ilanbiala no I wouldn't say "not be used' that's too harsh. I think we should do the same as in the docs which I recommended @codydaig earlier - let's just say that the generator uses the 0.3.0 version of meanjs |
### Cloning The GitHub Repository | ||
You can also use Git to directly clone the MEAN.JS repository: | ||
The reccommended way to get MEAN.js is to use git to directly clone the MEAN.JS repository: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra c
e2a2a0b
to
0c05188
Compare
@lirantal LGTM. Merge when you are ready. |
@ilanbiala @lirantal I don't know if m latest change is showing up. Travis CI saw my changes but GitHub is still showing my old commit (for me at least) |
@ilanbiala so you don't want to keep the yeoman generator section with saying that it's for the 0.3.0 version? |
@codydaig so again, for now I vote for keeping the Yo Generator paragraph but having it say that it works with the 0.3.0 branch and not the current master/0.4.0 release, and I'll also switch that section with the Cloning The GitHub Repository section so the latter is showing up first. WDYT? |
@lirantal Is the latest view what you were thinking? (I'll squash before we merge this in.) |
yep. |
66a681c
to
c539cdb
Compare
Squashed. |
@lirantal good to merge or did you want anything else changed? |
Update generator references from readme and index
yep, thanks for pushing that. |
Removed generator references from the README and index view.
@ilanbiala @lirantal - I would suggest this get merged into 0.4.0 prior to the release to prevent confusion.