This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Require login #700
Merged
Require login #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A state parameter was added for the routes that require user authentication. Now, everytime a statechange occurs, the destination state is checked and user is redirected to signin page if necessary. Note the state parameter is added within `data`, so that nested states can inherent its value.
|
Supersedes #686 Great work @igorauad and @trainerbill LGTM @lirantal |
|
|
||
| if (!allowed) { | ||
| event.preventDefault(); | ||
| $state.go('authentication.signin', {}, { |
There was a problem hiding this comment.
Is there a reason why this sends the user to the signin route? Shouldn't it take them 'home'?
|
Closed #686 |
|
@mleanos looks like I missed your comment there before merging in. @trainerbill ? |
rhutchison
added a commit
to Gym/mean
that referenced
this pull request
Jul 25, 2015
update displayName implements meanjs#700 (client-side role security) on angular routes.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR for requiring client side roles. Props to @igorauad for the idea.