This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Added Visual Studio files to gitignore #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding files to ignore that are related to Visual Studio, and Node.js development within the VS environment.
|
LGTM |
|
@lirantal I'm fine with the change, but what I don't like is all the editors going before the general files. Thoughts? |
|
@ilanbiala I agree. As the list of editors grows, it will push the general settings down further. Would be nice to add all editor files after any other settings. |
I moved all the editor files underneath all the other settings. As the editor list grows, it will help keep things organized, and editor configs are less pertinent to individual developers.
|
Per @ilanbiala request, I moved the editor files to the bottom of the gitignore file. I think this is better. |
|
Cool, LGTM. |
ilanbiala
added a commit
that referenced
this pull request
Jul 24, 2015
Added Visual Studio files to gitignore Rearranged gitignore to prioritize general files over editor files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding files to ignore that are related to Visual Studio, and Node.js
development within the VS environment.
This is my first PR for a forked repo. I figured it's a good starting point, to get used to the flow of PR's, and contributing to this project. Also, it will help keep my fork clean from VS files moving forward.
@lirantal @ilanbiala Please let me know if this is an appropriate PR, and that I'm following the proper flow for this project. Thanks.