Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Adding missing envs for docker / fig in development and test #428

Closed
wants to merge 1 commit into from

Conversation

luebken
Copy link
Contributor

@luebken luebken commented Feb 23, 2015

Currently the Docker setup only works for ‘production’ environment. Since the default is development (See https://github.com/meanjs/mean/blob/master/fig.yml#L8) a fig up results in a database connection error.

It mimics the change that has already been merged to production.js: 83686b8
https://github.com/meanjs/mean/blob/master/config/env/production.js#L5

This PR is an update from #183

It fixes #222, #237, #342, #142

@thecb4
Copy link

thecb4 commented Mar 27, 2015

development.js file has

db: 'mongodb://localhost/mean'

fig.yml (now docker-compose.yml) has

  links:
   - db

change development.js to 'db' instead of 'localhost'

db: 'mongodb://db/mean'

works perfectly

@ilanbiala
Copy link
Member

Please use GFM to properly highlight code blocks.

@luebken
Copy link
Contributor Author

luebken commented Mar 27, 2015

change development.js to 'db' instead of 'localhost'

correct that uses the hosts entry instead of the envs.

The other config files use envs so I would stay with envs. Also you want to have it keep working with localhost.

So from my point of view this PR is still valid. Any pointers / corrections appreciated

@lirantal
Copy link
Member

thanks @luebken but we have it implemented already in 0.4.0 branch.

@lirantal lirantal closed this Jul 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing envs for docker / fig in development and test
4 participants