Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Client side test coverage #663

Closed
cdriscol opened this issue Jul 19, 2015 · 8 comments
Closed

Client side test coverage #663

cdriscol opened this issue Jul 19, 2015 · 8 comments

Comments

@cdriscol
Copy link
Contributor

I'm working on client side test coverage in my own fork. I'm happy to create PR's, but wasn't sure if the extra coverage would be useful or not to others.. any interest?

edit: this is on the 0.4.0 branch

@codydaig
Copy link
Member

+1

@cdriscol
Copy link
Contributor Author

Here is the branch I am working from.

Currently a work in progress, but open for any suggestions.

@lirantal
Copy link
Member

we're definitely pro-tests so please submit a PR for 0.4.0 when you're ready with some tests and we can review them for merge.
Thanks @cdriscol

@lirantal
Copy link
Member

@cdriscol I can't assign to you specifically but consider yourself assigned :-)
Can you estimate the work required here before you can provide a PR with good coverage and quality tests? I would like to see this for 0.4.0 so we can introduce testing on the angular side.

@lirantal lirantal mentioned this issue Jul 20, 2015
14 tasks
@cdriscol
Copy link
Contributor Author

@lirantal - I should have angular 100% tested this week.

@lirantal
Copy link
Member

@cdriscol That would be an amazing accomplishment, looking forward.

@trainerbill
Copy link
Contributor

@cdriscol Dude this looks awesome. We will also be merging in some admin functionality that will need tests. Do you want to volunteer for these when the functionality is added? :) #676

@cdriscol
Copy link
Contributor Author

@trainerbill - I can throw in some tests for that! I've been really busy this week with some other stuff - but will be jumping back into my test branch today and tomorrow. I'll take a look at the admin module as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants