[TS2.2.x] Operator '!==' cannot be applied to types

[beeman]

What type of issue are you creating?

• Bug

What version of this module are you using?

• 2.1.0-rc.8.3

Please add a description for your issue:

When running the generated SDK in a project with TypeScript 2.2.1 it results in an error:

ERROR in /Users/beeman/workspace/scratch/loopback-scratch/client/src/app/shared/sdk/services/core/search.params.ts (34,42): Operator '!==' cannot be applied to types '"string" | "number" | "boolean" | "symbol" | "undefined" | "object" | "function"' and '"array"'.)
/Users/beeman/workspace/scratch/loopback-scratch/client/src/app/shared/sdk/services/core/search.params.ts (37,50): Operator '===' cannot be applied to types '"string" | "number" | "boolean" | "symbol" | "undefined" | "object" | "function"' and '"array"'.)

There is an example project here.

Workaround

Downgrade the Angular app to TypeScript 2.1.6.

[jmls]

I think that there's some logic problem in that code anyway ...

    private _parseParam(key: string, value: any, parent: string) {
        if (typeof value !== 'object' && typeof value !== 'array') {
            return parent ? parent + '[' + key + ']=' + value
                          : key + '=' + value;
        } else if (typeof value === 'object' ||  typeof value === 'array') {
            return parent ? this._JSON2URL(value, parent + '[' + key + ']')
                          : this._JSON2URL(value, key);
        } else {
            throw new Error('Unexpected Type');
        }
    }

so, if the value is not an object and not an array, hit the first test
if it doesn't pass the first test, then it must be an array or object, so the second test is irrelevant - and this makes the last else completely redundant.

In fact, if there is an unexpected type, it's actually caught by the first test

[jmls]

if you replace the _parseParam function with this code, the typescript error goes away

private _parseParam(key: string, value: any, parent: string) {
        let typeofValue:string = typeof value;

        if (typeofValue !== 'object' && typeofValue !== 'array') {
            return parent ? parent + '[' + key + ']=' + value
                          : key + '=' + value;
        } else {
            return parent ? this._JSON2URL(value, parent + '[' + key + ']')
                          : this._JSON2URL(value, key);
        }
    }

[ferares]

That works, can you make a pull request, or should I?

[jonathan-casarrubias]

I will be integrating this fix as soon as the pull request points to development.

Thanks for reporting and also for fixing the issue.

[Wavfact]

This is still an issue in Typescript 2.3.4

Found this bug while researching the error message i was getting after upgrading.

[beeman]

@Wavfact your error seems to come from one of these files, which are not part of the SDK:

src/app/pipes/MyCurrencyPipe.ts or src/app/commercial/directives/numbers-only.directive.ts

[Wavfact]

I downgraded to 2.1.6 as you suggested above and the issue was resolved..

In those files, there was a typescript error using typeof <var> !== "String" Thats why I posted that the issue has not been resolved yet.

[beeman]

If the issue is indeed in
src/app/pipes/MyCurrencyPipe.ts and src/app/commercial/directives/numbers-only.directive.ts you should just fix those files. No need to downgrade the TypeScript 2.1.6