Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue building ng2 with rxjs-rc #250

Closed
4 tasks
redaikidoka opened this issue Dec 12, 2016 · 1 comment · Fixed by #251
Closed
4 tasks

Issue building ng2 with rxjs-rc #250

redaikidoka opened this issue Dec 12, 2016 · 1 comment · Fixed by #251

Comments

@redaikidoka
Copy link

What type of issue are you creating?

  • [ X ] Bug
  • Enhancement
  • Question

What version of this module are you using?

  • 2.0.10 (Stable)
  • [ X ] 2.1.0-rc.2 (2.1 Release Candidate n)
  • Other

Write other if any:

Please add a description for your issue:

When building my app with the generated code, and using the newer react:
"rxjs": "5.0.0-rc.5",

there is a build error:
[default] /src/app/shared/datasdk/services/core/error.service.ts:12:39

which can be corrected by giving the ErrorObservable return value a type, cum sa:

@Injectable() export class ErrorHandler { public handleError(error: Response): ErrorObservable<string> { return Observable.throw(error.json().error || 'Server error'); } }

@jonathan-casarrubias
Copy link
Collaborator

Hey @redaikidoka thanks for reporting I will add a fix for this ASAP.

Cheers
Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants