Fix TypeScript error: Cannot find name 'Fragment'. #1615
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/3sdwbvUUm5AvQLrD8BHELX7ege9m |
| @@ -4,6 +4,7 @@ import { | |||
| Context, | |||
| Consumer, | |||
| ComponentType, | |||
| Fragment, | |||
There was a problem hiding this comment.
Fixes:
~/mdx/packages/react $ yarn test
Error: /home/nottheoilrig/mdx/packages/react/types/index.d.ts:68:20
ERROR: 68:20 expect [email protected] compile error:
Cannot find name 'Fragment'.| @@ -3,7 +3,6 @@ | |||
| "module": "commonjs", | |||
| "lib": ["dom", "es6"], | |||
| "strict": true, | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
Stop omitting TypeScript errors from automated tests: sed --in-place /skipLibCheck/d **/tsconfig.json
There was a problem hiding this comment.
This option enabled makes ts ignoring errors in .d.ts, right? But what if there are some errors from node_modules?
There was a problem hiding this comment.
This option enabled makes ts ignoring errors in
.d.ts, right?
Yup.
But what if there are some errors from
node_modules?
If a way exists to verify our .d.ts without also checking declarations in node_modules, I don't know it ... 🤔 Could we use our dependencies/devDependencies and semvers to keep broken types out of node_modules? If that works, it would probably be the friendliest thing to our downstream types consumers?
There was a problem hiding this comment.
OK, maybe we can raise a feature request for TypeScript?
There was a problem hiding this comment.
I ran into an issue: Since dropping skipLibChecks we're checking the following .d.ts:
- our explicit
node_modulesdependencies - every
node_modules/@typesdeclaration 😂
#1622 adds "types": [], to at least only check our explicit dependencies.
| @@ -1,4 +1,4 @@ | |||
| // TypeScript Version: 3.4 | |||
| // TypeScript Version: 3.5 | |||
There was a problem hiding this comment.
Fixes:
~/mdx/packages/preact $ yarn test
Error: Errors in [email protected] for external dependencies:
../../../node_modules/preact/src/jsx.d.ts(310,6): error TS2304: Cannot find name 'Omit'.Preact depends on TypeScript 3.5: preactjs/preact#2581
Add
import { Fragment } from "react", missed in #1514 ❤️