Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to use classic runtime #1346

Closed
wants to merge 1 commit into from
Closed

Conversation

michrome
Copy link

This is a copy of #1307 but for MDX@2. It's to avoid the error pragma and pragmaFrag cannot be set when runtime is automatic which is a result of React's new JSX Transform.

Related discussion at #1345 .

@vercel
Copy link

vercel bot commented Nov 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/ffkib33sr
✅ Preview: https://mdx-git-next.mdx.now.sh

@vercel vercel bot temporarily deployed to Preview November 18, 2020 22:43 Inactive
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brandonweiss !

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonweiss when you have a chance could you look into updating the test cases for the generated code https://github.com/mdx-js/mdx/pull/1346/checks?check_run_id=1421073559#step:9:70
to include the new comment/pragma?

@wooorm
Copy link
Member

wooorm commented Nov 19, 2020

Yes, would be good to get that updated fixture in there.
If you’re having troubles with the repo that might be addressed in #1338, in which case I’m fine landing your PR first and I’ll fix it later.

@codejunkienick
Copy link

Is it possible to publish this any time soon? It will help with projects which use MDX and Emotion, in my case Storybook

@wooorm
Copy link
Member

wooorm commented Dec 17, 2020

@michrome Could you address the conflict, and Christian’s feedback (tests changed a bunch)?

@codejunkienick This PR is currently not mergeable as is.

@wooorm wooorm changed the base branch from next to main December 17, 2020 19:06
@wooorm
Copy link
Member

wooorm commented Dec 17, 2020

I cherry-picked all master (v1) changes and applied them on next (v2), which is now the main and default branch, so this is no longer needed, once it’s released. Thanks all!

@wooorm wooorm closed this Dec 17, 2020
@shuding
Copy link

shuding commented Feb 22, 2021

Hey @wooorm! Currently MDX v2 is breaking when using React 17 because of this issue. Is it possible to release a new v2 version any time soon?

@michrome
Copy link
Author

FYI @shuding b1b2cde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants