-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation to use classic runtime #1346
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/ffkib33sr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brandonweiss !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandonweiss when you have a chance could you look into updating the test cases for the generated code https://github.com/mdx-js/mdx/pull/1346/checks?check_run_id=1421073559#step:9:70
to include the new comment/pragma?
Yes, would be good to get that updated fixture in there. |
Is it possible to publish this any time soon? It will help with projects which use MDX and Emotion, in my case Storybook |
@michrome Could you address the conflict, and Christian’s feedback (tests changed a bunch)? @codejunkienick This PR is currently not mergeable as is. |
I cherry-picked all master (v1) changes and applied them on next (v2), which is now the |
Hey @wooorm! Currently MDX v2 is breaking when using React 17 because of this issue. Is it possible to release a new v2 version any time soon? |
This is a copy of #1307 but for MDX@2. It's to avoid the error
pragma and pragmaFrag cannot be set when runtime is automatic
which is a result of React's new JSX Transform.Related discussion at #1345 .