Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): update github actions and dtslint to latest #1178

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Jul 23, 2020

dependency updates may help resolve flaky tests which have been occuring on next branch.

dtslint updated using yarn upgrade dtslint

related to #1172

@ChristianMurphy ChristianMurphy added 🕸️ area/tests This affects tests 💎 v2 Issues related to v2 👶 semver/patch This is a backwards-compatible fix labels Jul 23, 2020
@ChristianMurphy ChristianMurphy requested a review from a team July 23, 2020 00:39
@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/6wucdp5sl
✅ Preview: https://mdx-git-fork-christianmurphy-v2-github-actions-dtslint-update.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview July 23, 2020 00:39 Inactive
@ChristianMurphy
Copy link
Member Author

ChristianMurphy commented Jul 23, 2020

@johno there is still a test error, but in the unit tests, and it appears to be unrelated to these changes

1..166
# tests 166
# pass  153
# fail  13

see https://github.com/mdx-js/mdx/pull/1178/checks?check_run_id=900934958 for full details.

@ChristianMurphy ChristianMurphy requested a review from johno July 23, 2020 00:52
dependency updates may help resolve flaky tests which have been occuring on `next` branch
@ChristianMurphy ChristianMurphy force-pushed the v2-github-actions-dtslint-update branch from 6113da7 to 5636572 Compare July 23, 2020 01:06
@vercel vercel bot temporarily deployed to Preview July 23, 2020 01:06 Inactive
@johno
Copy link
Member

johno commented Jul 23, 2020

Oh weird, yeah looks like it might be a cross-platform issue, we can dig into that later. Thank you for the updates for types, let's see if that makes things more stable!

@johno johno merged commit cc95646 into mdx-js:next Jul 23, 2020
@ChristianMurphy ChristianMurphy deleted the v2-github-actions-dtslint-update branch November 21, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ area/tests This affects tests 👶 semver/patch This is a backwards-compatible fix 💎 v2 Issues related to v2
Development

Successfully merging this pull request may close these issues.

2 participants