Feature/optional last response preserving #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iansparks @glow-mdsol |
|
Looks good to me. |
|
@jmann-mdsol @glow-mdsol @isparks-tg @isparks-tg |
|
@rosh-n-ix can approve but not my place to merge. Defer to someone at Medidata, @glow-mdsol ? |
|
Let me do a quick PR to resolve the issue with CI, then we can merge that and get this pulled in |
Merged
|
Ok, should be good to update from develop and then we can get this released |
rosh-n-ix
force-pushed
the
feature/optional_last_response_preserving
branch
from
89d85a1 to
85726f0
Compare
|
@glow-mdsol done! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When fetching clinical data, there are cases where files exceeding 2 GB are being transferred. Currently, the client always retains the response object in a class property, which results in doubling the memory usage.
Solution:
In this pull request, I’ve made the preservation of the response object optional. This change reduces memory consumption by preventing the client from unnecessarily holding the response object in memory, especially for large file transfers.
Also: Error catching was refactored, test added, lib version updated