-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate templates with an option to preserve existing changes #75
Conversation
@@ -109,9 +109,18 @@ directory are provided: | |||
Run the following command to generate them: | |||
|
|||
``` | |||
[bundle exec] rake config:generate_all | |||
[bundle exec] rake config:generate_all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space
@jcarres-mdsol im thinking maybe its cleaner if I create separate 'force' generate tasks config:generate_all:force
config:generate:force[filename, location] This will get rid of the additional boolean input. any thoughts? |
@atierney-mdsol on one hand sounds good, easier to call. On the other hand we already have a bunch of tasks, I think it will be confusing for users to have too many tasks to choose from and pollute the rails tasks. |
@atrivedi-mdsol think I got tagged in by mistake 😄 |
@@ -1,3 +1,8 @@ | |||
# 0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can pretty much declare 1.0.0 , as we for all purposes we are treating this gem as semver, no point of staying in 0.x versions
@jcarres-mdsol I did a very extensive poll (i.e. asked 2 people at work) about which task seem easier. they seem to prefer |
@atrivedi-mdsol The poll seems extensive enough to me. |
Thanks @jcarres-mdsol. I updated travis.yml and .ruby-version NoMethodError: undefined method `spec' for nil:NilClass
An error occurred while installing dice_bag (1.0.0), and Bundler cannot
continue Some gem dependency you reckon? |
looks like CI failure is caused by rubygems/bundler#3559 |
Probably can be solved by updating to latest bundler version before running install:
On Wed, Dec 16, 2015 at 9:48 PM, Abhi Trivedi [email protected]
Jordi Polo Carres | Software Architect | Medidata Solutions Worldwide |
Oh, it seems it passed. I'm having problems with Travis and bundler this couple of days, maybe they solved them. Merging! 🎉 |
Generate templates with an option to preserve existing changes
changes to
config:generate_all
so it allows user the option to review the diff and preserve any project specific customization.