Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic support for auto reverse-complements #120

Merged
merged 3 commits into from
Jul 25, 2017

Conversation

tolot27
Copy link
Contributor

@tolot27 tolot27 commented Jul 25, 2017

Added basic support for reverse-complement a sequence automatically, if the start coordinate of a range is larger than the end coordinate.

It is useful, i.e. to directly extract subsequences based on BLAST hit coordinates without dealing with its strandness.

…if the start coordinate of a range is larger than the end coordinate.
@tolot27
Copy link
Contributor Author

tolot27 commented Jul 25, 2017

Maybe I should test strict_bounds, too?

@mdshw5
Copy link
Owner

mdshw5 commented Jul 25, 2017

I’d gladly accept this but would like to know if complementing the sequence is expected behavior. Can you point me to an example of coordinates working this way in another program?

@swheelan
Copy link
Collaborator

swheelan commented Jul 25, 2017 via email

@tolot27
Copy link
Contributor Author

tolot27 commented Jul 25, 2017

Not only complementing, also reversing. ;-)
A flag would be sufficient.

@mdshw5
Copy link
Owner

mdshw5 commented Jul 25, 2017

Thanks, @swheelan. @tolot27: I'll merge the changes and add a flag --auto-strand flag to the script.

Repository owner deleted a comment from codecov bot Jul 25, 2017
Repository owner deleted a comment from codecov bot Jul 25, 2017
mdshw5 added a commit that referenced this pull request Jul 25, 2017
Repository owner deleted a comment from codecov bot Jul 25, 2017
@mdshw5 mdshw5 merged commit a2d17e1 into mdshw5:master Jul 25, 2017
mdshw5 added a commit that referenced this pull request Jul 25, 2017
mdshw5 added a commit that referenced this pull request Jul 25, 2017
mdshw5 added a commit that referenced this pull request Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants