Bug fix in blockette code from 2019

[anilyil]

Purpose

The blockette code had a bug when transferring face velocities to the blockette data. This code is not used for steady state, non rotating meshes. I am not sure if this was the reason rotating cases were not working with blockettes or we ignored some other terms as well.

Expected time until merged

Instant-merge

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

Checklist

• I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
• I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[codecov]

Codecov Report

Merging #297 (23e7851) into main (c246e06) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   42.39%   42.39%           
=======================================
  Files          13       13           
  Lines        3963     3963           
=======================================
  Hits         1680     1680           
  Misses       2283     2283           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[marcomangano]

Let me check this on one of my cases!

[sseraj]

I tested this by running test_adjoint.py:TestAdjoint_4_Rotating_wing.test_residuals with "useBlockettes": True. Without the fix in this PR, the test fails. With this fix, the test passes.

[marcomangano]

I tested this by running test_adjoint.py:TestAdjoint_4_Rotating_wing.test_residuals with "useBlockettes": True. Without the fix in this PR, the test fails. With this fix, the test passes.

Shall we then change that option for the rotating wing test? I tested it as well and confirm it works

[anilyil]

I don't think we test with blockettes on for the others either. It's good to leave it as is.