Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ai-help): log message metadata #424

Merged
merged 27 commits into from
Mar 26, 2024
Merged

feat(ai-help): log message metadata #424

merged 27 commits into from
Mar 26, 2024

Conversation

fiji-flo
Copy link
Contributor

Resolves MP-813

@fiji-flo fiji-flo requested a review from a team as a code owner February 21, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner caugner self-assigned this Feb 27, 2024
caugner
caugner reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fiji-flo I asked "What is HTML?" locally and the resulting row has query_len = 0 and context_len = 0. Any ideas why that is?

@caugner caugner force-pushed the MP-813-message-metadata branch from 81de565 to 7bbf8db Compare February 29, 2024 12:54
@caugner caugner force-pushed the MP-813-message-metadata branch from 7bbf8db to 4572cd4 Compare February 29, 2024 12:57
caugner
caugner approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally with all 5 example questions, both as a free and paying user:

image

caugner
caugner requested changes Feb 29, 2024
View reviewed changes
@caugner caugner mentioned this pull request Feb 29, 2024
Closed
@caugner caugner force-pushed the MP-813-message-metadata branch from 691f302 to 69243f9 Compare February 29, 2024 20:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner caugner mentioned this pull request Mar 4, 2024
Merged
@caugner caugner self-requested a review March 4, 2024 11:43
caugner
caugner requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more non-nits, otherwise LGTM, but another review pass by @argl would be good, since I contributed myself to this PR.

@caugner caugner marked this pull request as draft March 4, 2024 13:33
@caugner caugner removed their assignment Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@fiji-flo fiji-flo marked this pull request as ready for review March 25, 2024 21:05
@fiji-flo fiji-flo requested a review from caugner March 25, 2024 21:05
caugner
caugner approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tested locally.

@caugner caugner merged commit d035afa into main Mar 26, 2024
3 checks passed
@caugner caugner deleted the MP-813-message-metadata branch March 26, 2024 17:43
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiji-flo @caugner