-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Mozilla/Firefox/Privacy to Web/Privacy #4729
Conversation
@annevk Try running |
That suggests the redirects are orphaned and removes them, which seems bogus? |
I suspect those are just warnings during the run of that. |
Perhaps try this. Manually delete the two lines from the
push that and we'll see if it works. |
Assuming s/tool/content/ I get back
|
Oh no. I think we'll need to delete all lines from the |
Context is this PR: mdn/content#4729
Context is this PR: mdn/content#4729
I think what happened was that the mozilla/firefox/privacy was considered archived in the initial migration to Yari. Then it was un-archived and now it's not only un-archived (again), but it's being moved too. mdn/yari#3716 will hopefully solve your problems but once that lands you'll need to upgrade the version of |
CI issues are resolved now, thanks! #4729 (comment) still lists some issues, but despite it saying it was last updated recently the information appears stale as I cannot find the broken links it talks about. So I think this is good for review now. cc @johannhof |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked this out locally and tested it, and it all looks fine for now. The page locations look correct, and the redirects work.
I think I'm going to merge this now, and you can work more on the content later on.
Context is this PR: mdn/content#4729
There's a lot more that can be done here with regards to having more vendor-neutral introductions and pointers to relevant specifications, but hopefully this seems like a reasonable first step.