Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mozilla/Firefox/Privacy to Web/Privacy #4729

Merged
merged 4 commits into from
May 6, 2021
Merged

Move Mozilla/Firefox/Privacy to Web/Privacy #4729

merged 4 commits into from
May 6, 2021

Conversation

annevk
Copy link
Contributor

@annevk annevk commented May 5, 2021

There's a lot more that can be done here with regards to having more vendor-neutral introductions and pointers to relevant specifications, but hopefully this seems like a reasonable first step.

@annevk annevk requested review from a team as code owners May 5, 2021 13:14
@annevk annevk requested review from chrisdavidmills and removed request for a team May 5, 2021 13:14
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Preview URLs

Flaws

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors
Title: Errors
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors/CookieBlockedByPermission
    • Can't resolve /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors/CookieBlockedTracker
    • Can't resolve /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors/CookieBlockedAll
    • Can't resolve /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors/CookieBlockedForeign
    • Can't resolve /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors/CookiePartitionedForeign

URL: /en-US/docs/Web/Privacy/Redirect_tracking_protection
Title: Redirect tracking protection
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Privacy/Storage_access_policy#tracking_protection_explained
    • Can't resolve /en-US/docs/Mozilla/Firefox/Privacy/Storage_access_policy#tracking_protection_explained

URL: /en-US/docs/Web/API/Storage_Access_API
Title: Storage Access API
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

External URLs

URL: /en-US/docs/Web/Privacy
Title: Privacy, permissions, and information security
on GitHub

No new external URLs


URL: /en-US/docs/Web/Privacy/Storage_Access_Policy
Title: Storage access policy: Block cookies from trackers
on GitHub


URL: /en-US/docs/Web/Privacy/Storage_Access_Policy/Errors
Title: Errors
on GitHub

No new external URLs


URL: /en-US/docs/Web/Privacy/Storage_access_policy/Errors/CookiePartitionedForeign
Title: Partitioned: All third-party storage access requests
on GitHub

No external URLs


URL: /en-US/docs/Web/Privacy/Storage_access_policy/Errors/CookieBlockedForeign
Title: Blocked: All third-party storage access requests
on GitHub


URL: /en-US/docs/Web/Privacy/Storage_access_policy/Errors/CookieBlockedAll
Title: Blocked: All storage access requests
on GitHub


URL: /en-US/docs/Web/Privacy/Storage_access_policy/Errors/CookieBlockedByPermission
Title: Blocked: Custom cookie permission
on GitHub


URL: /en-US/docs/Web/Privacy/Storage_access_policy/Errors/CookieBlockedTracker
Title: Blocked: Storage access requests from trackers
on GitHub


URL: /en-US/docs/Web/Privacy/Tracking_Protection
Title: Tracking Protection
on GitHub


URL: /en-US/docs/Web/Privacy/State_Partitioning
Title: State Partitioning
on GitHub


URL: /en-US/docs/Web/Privacy/Redirect_tracking_protection
Title: Redirect tracking protection
on GitHub


URL: /en-US/docs/Web/API/Document/requestStorageAccess
Title: Document.requestStorageAccess()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Storage_Access_API
Title: Storage Access API
on GitHub

No new external URLs

(this comment was updated 2021-05-06 06:46:54.281181)

@peterbe
Copy link
Contributor

peterbe commented May 5, 2021

@annevk Try running yarn content fix-redirects and see what that does.

@annevk
Copy link
Contributor Author

annevk commented May 5, 2021

That suggests the redirects are orphaned and removes them, which seems bogus?

@peterbe
Copy link
Contributor

peterbe commented May 5, 2021

That suggests the redirects are orphaned and removes them, which seems bogus?

I suspect those are just warnings during the run of that.
The person who wrote most of this tooling is on PTO. Even I struggle to understand them.

@peterbe
Copy link
Contributor

peterbe commented May 5, 2021

Perhaps try this. Manually delete the two lines from the _redirects.txt file so it goes back to same as main. Then, run:

yarn tool add-redirect /en-US/docs/Mozilla/Firefox/Privacy /en-US/docs/Web/Privacy

push that and we'll see if it works.

@annevk
Copy link
Contributor Author

annevk commented May 5, 2021

Assuming s/tool/content/ I get back

error: From-URL resolves to a file ($ARCHIVED/en-us/mozilla/firefox/privacy/index.html)

@peterbe
Copy link
Contributor

peterbe commented May 5, 2021

Oh no. I think we'll need to delete all lines from the content/archived.txt in Yari first.
I just don't understand why it was in there and always has been for the last 3 months. I'll take care of that.

peterbe added a commit to mdn/yari that referenced this pull request May 5, 2021
peterbe added a commit to mdn/yari that referenced this pull request May 5, 2021
@peterbe
Copy link
Contributor

peterbe commented May 5, 2021

I think what happened was that the mozilla/firefox/privacy was considered archived in the initial migration to Yari. Then it was un-archived and now it's not only un-archived (again), but it's being moved too.

mdn/yari#3716 will hopefully solve your problems but once that lands you'll need to upgrade the version of @mdn/yari in your content repo. So, in a matter 30min you should be able to merge in the latest main for mdn/content and then run yarn install.

@annevk
Copy link
Contributor Author

annevk commented May 6, 2021

CI issues are resolved now, thanks! #4729 (comment) still lists some issues, but despite it saying it was last updated recently the information appears stale as I cannot find the broken links it talks about.

So I think this is good for review now.

cc @johannhof

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this out locally and tested it, and it all looks fine for now. The page locations look correct, and the redirects work.

I think I'm going to merge this now, and you can work more on the content later on.

@chrisdavidmills chrisdavidmills merged commit fcff34a into mdn:main May 6, 2021
@annevk annevk deleted the annevk/privacy branch May 6, 2021 07:51
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants