Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ShadowRootInit.slotAssignment #16666

Closed
wants to merge 2 commits into from
Closed

Document ShadowRootInit.slotAssignment #16666

wants to merge 2 commits into from

Conversation

Peeja
Copy link

@Peeja Peeja commented May 25, 2022

Summary

Documents the (new-ish) manual slot assignment mode (slotAssignment: 'manual').

Motivation

I was trying to get HTMLSlotElement.assign() to work, but I couldn't get anything to happen. Turns out there's an option to turn it on, it just wasn't on MDN yet. 😄

Supporting details

Related issues

Fix #8782

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

TODO

  • I'd like to update the HTMLSlotElement.assign() page to mention this as well. That would have been the hook I needed to see this the first time.

@github-actions github-actions bot added the Content:WebAPI Web API docs label May 25, 2022
@Josh-Cena
Copy link
Member

@Peeja Do you plan to complete your TODO any time soon? Documentation had been added in #20197 but it's nowhere as complete as yours, and I do want to see the assign() reference being updated as well.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Element/attachShadow
Title: Element.attachShadow()
Flaw count: 6

  • macros:
    • /en-US/docs/Web/HTML/Element/h1 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h3 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h4 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h5 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • and 1 more flaws omitted

@bsmth
Copy link
Member

bsmth commented Oct 5, 2022

I'm going to close this one for now because it's inactive. @Peeja if you would like to pick this up again, feel free to reopen! Thank you :)

@bsmth bsmth closed this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Element.attachShadow()": missing information about the slotAssignment option
3 participants