Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCDv6] Move webdriver.{commands => classic.commands} #25802

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 29, 2025

Summary

Moves webdriver.commands to webdriver.classic.commands.

Test results and supporting details

Related issues

Part of #20207.

@caugner caugner added the semver-major-bump A change that is potentially breaking for consumers label Jan 29, 2025
@github-actions github-actions bot added data:webdriver Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver size:xl [PR only] >1000 LoC changed labels Jan 29, 2025
@caugner caugner changed the title Move webdriver.commands => webdriver.classic.commands Move webdriver.{commands => classic.commands} Jan 29, 2025
@caugner caugner changed the title Move webdriver.{commands => classic.commands} [BCDv6] Move webdriver.{commands => classic.commands} Jan 29, 2025
@caugner
Copy link
Contributor Author

caugner commented Jan 31, 2025

@Elchi3 @queengooborg Do we really consider this a semver-major-bump change, or couldn't this land in a minor version?

@queengooborg
Copy link
Contributor

While our semantic versioning policy would only count this as a patch change, it's a big enough change that I think we should include it in the v6 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webdriver Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver semver-major-bump A change that is potentially breaking for consumers size:xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants