-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new declarativeNetRequest RuleConditions #24253
Add new declarativeNetRequest RuleConditions #24253
Conversation
5865ead
to
72dbf13
Compare
72dbf13
to
91f24a7
Compare
I also opened mdn/content#35649, but it uses this BCD data so this needs to be merged first. I followed the example of https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleAction#browser_compatibility with the new conditions, thinking forward to creating the page https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/HeaderInfo (https://pr35649.content.dev.mdn.mozit.cloud/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/HeaderInfo) and for that page using a similar structure to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/ModifyHeaderInfo#browser_compatibility |
This pull request has merge conflicts that must be resolved before it can be merged. |
91f24a7
to
7ca17ee
Compare
I have applied the requested changes. |
@queengooborg Can I get this and/or the associated content PR merged if you approve of it? |
Summary
Add new declarativeNetRequest RuleConditions responseHeaders and excludedResponseHeaders
Test results and supporting details
https://issues.chromium.org/issues/40727004
https://bugzilla.mozilla.org/show_bug.cgi?id=1877486
https://bugs.webkit.org/show_bug.cgi?id=275158
w3c/webextensions#460
https://developer.chrome.com/docs/extensions/reference/api/declarativeNetRequest#property-RuleCondition-excludedResponseHeaders
https://developer.chrome.com/docs/extensions/reference/api/declarativeNetRequest#property-RuleCondition-responseHeaders
https://developer.chrome.com/docs/extensions/reference/api/declarativeNetRequest#type-HeaderInfo.
Fixes #24186