Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'available_in_workers' with 'worker_support' #2362

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Replace 'available_in_workers' with 'worker_support' #2362

merged 1 commit into from
Jun 25, 2018

Conversation

connorshea
Copy link
Contributor

Replaces all uses of available_in_workers with worker_support.

Resolves #2351.

cc: @Elchi3

@connorshea connorshea mentioned this pull request Jun 25, 2018
Closed
@ExE-Boss
Copy link
Contributor

You should probably add a comment about this to compat-data-schema.md, README.md or somewhere.

needinfo?(@Elchi3): Into which file would this information fit best?

@Elchi3
Copy link
Member

Elchi3 commented Jun 25, 2018 •
edited
Loading

In compat-data-schema.md is likely best. Probably an own section there on API compat makes sense to have this and other conventions documented (like also the one about API constructors). Can get done in a new PR, if you like.

@connorshea
Copy link
Contributor Author

Let's put that in a separate PR :)

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 25, 2018
Elchi3
Elchi3 approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@Elchi3 Elchi3 merged commit f1ea4d1 into mdn:master Jun 25, 2018
@connorshea connorshea mentioned this pull request Jun 26, 2018
Merged
@connorshea connorshea deleted the standardize-worker-subfeature-name branch July 10, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorshea @ExE-Boss @Elchi3