Remove RTCIdentityEvent and RTCIdentityErrorEvent #11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
added
needs-release-note 📰
needs content update
github-actions
bot
added
the
data:api
foolip
force-pushed
the
rm-rtc-identity-events
branch
from
36d137b to
dd9388b
Compare
These were only ever implemented in Firefox and removed in 2015: https://bugzilla.mozilla.org/show_bug.cgi?id=975144 mozilla/gecko-dev@e92b44d The events identityresult, peeridentity, idpassertionerror and idpvalidationerror were also removed then. The data claiming support in Edge 18 for some of this is wrong, confirmed by testing Edge 18 with these tests: https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidentityresult https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidpassertionerror https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidpvalidationerror https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onpeeridentity
foolip
force-pushed
the
rm-rtc-identity-events
branch
from
dd9388b to
8343742
Compare
foolip
commented
Jun 18, 2021
| "ie": { | ||
| "version_added": false | ||
| }, | ||
| "opera": [ |
There was a problem hiding this comment.
This data doesn't make any sense, but to be sure I've disconfirmed it in Opera 77 using https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidentityresult.
foolip
commented
Jun 18, 2021
| "version_added": false | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": "6.0" |
There was a problem hiding this comment.
This is as implausible as it gets, also disconfirmed with https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidentityresult.
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 18, 2021
foolip
removed
the
needs content update
|
This got bigger than I thought, but this + mdn/content#6109 should cover the same cleanup now. |
sideshowbarker
pushed a commit
to mdn/content
that referenced
this pull request
Jun 18, 2021
queengooborg
approved these changes
Jun 18, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 24, 2021
ddbeck
added a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were only ever implemented in Firefox and removed in 2015:
https://bugzilla.mozilla.org/show_bug.cgi?id=975144
mozilla/gecko-dev@e92b44d
The events identityresult, peeridentity, idpassertionerror and
idpvalidationerror were also removed then.
The data claiming support in Edge 18 for some of this is wrong,
confirmed by testing Edge 18 with these tests:
https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidentityresult
https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidpassertionerror
https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onidpvalidationerror
https://mdn-bcd-collector.appspot.com/tests/api/RTCPeerConnection/onpeeridentity
The data was added in #987.